Hi Michael
Tthe problem is that you are linking to an Analysis workspace that is in your Favorites folder. By default only you or admins have access to your Favorites.
You you need to move or save the analysis workspace to a public folder then generate and share the link.
Regards